Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Console app #105

Merged
merged 18 commits into from
Sep 11, 2018
Merged

Console app #105

merged 18 commits into from
Sep 11, 2018

Conversation

TheAngryByrd
Copy link
Owner

Proposed Changes

Allows scaffolding a console app version of MiniScaffold

Types of changes

What types of changes does your code introduce to MiniScaffold?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Build and tests pass locally
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@TheAngryByrd TheAngryByrd force-pushed the console-app branch 2 times, most recently from 3a1a3f2 to 9d6c96d Compare September 6, 2018 20:11
@TheAngryByrd TheAngryByrd force-pushed the console-app branch 3 times, most recently from 45d93d6 to e0352c3 Compare September 9, 2018 17:46
@TheAngryByrd TheAngryByrd changed the title WIP: Console app Console app Sep 9, 2018
@TheAngryByrd
Copy link
Owner Author

CI keeps failing due to some mono/paket issue.

Copy link
Collaborator

@baronfel baronfel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I added a couple of enhancements on the other PR.

@baronfel baronfel merged commit 24d230c into master Sep 11, 2018
@baronfel baronfel deleted the console-app branch September 11, 2018 20:03
TheAngryByrd pushed a commit that referenced this pull request Sep 11, 2018
* FEATURE: Console App Scaffold Support (#105)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants